-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework handling of mill-launcher
in MillBuildModule
#2703
Comments
mill-launcher
in MillBuildModule
As an alternative, we could embed the sources into the |
We should consider removing Things like OS-Lib, uPickle, Requests-Scala, etc. probably need to be there, but we don't want random things like |
I agree. Then, we probably just want to define a minimal classpath via We should try to embed these needed jars as resources in the mill-launcher, so we can create a minimal local ivy repository from it and use it for bootstrapping, so we don't need to download anything for the minimal |
Currently, we use the Mill launcher jar to compile the Mill project. To do that, we add it to the
unmanagedClasspath
of theMillBUildModule
. Technically, this is correct. But in comparison with dependencies defined viaivyDeps
we loose some semantics we'd like to keep. For example, when editing the build sources files, we don't have properly attached sources, as there is no metadata to use to get the sources jar on demand.Instead we could define the dependency under
ivyDeps
. There are some issues to that approach, too:mill-launcher
To overcome all of those issues, we could intercept the
ivyDeps
resolution of the binarymill-launcher
and return the already present jar.The text was updated successfully, but these errors were encountered: