Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent units check #33

Open
franaudo opened this issue Oct 18, 2020 · 1 comment
Open

consistent units check #33

franaudo opened this issue Oct 18, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@franaudo
Copy link
Contributor

most FEA software are unit-independent, but you still need to be consistent with the unit chosen. For example, if you use mm, s, ton then you need to specify stresses in MPa. This can be a huge source of errors, especially when the target user is not an engineer.

I am thinking of adding an (optional) parameter to the Model class to specify the units to be used for consistency checks.
These checks can be done for example by comparing the order of magnitude of certain elements (for example, the width and height of a section, or the density of a material) and pop up warnings in the log files.

I have also found this very interesting library: https://pint.readthedocs.io/en/0.10.1/tutorial.html
with this library, it is very easy to convert units and even use not-consistent units at the same time (the conversion happens in the background)

@franaudo franaudo added the enhancement New feature or request label Oct 18, 2020
@franaudo franaudo added this to the Release inside NCCR milestone Oct 18, 2020
@franaudo franaudo self-assigned this Oct 18, 2020
@rjodon
Copy link
Collaborator

rjodon commented Oct 19, 2020

I skimmed through Pint documentation, it sounds pretty sweet. However, be careful that unit conversion could go wrong between metric <-> Imperial if the number of digits is not enough and/or if we can't control it (I could not see yet a place where we define it in the API).

That's how we blow a rocket or crash a probe on a planet surface... :D

@tomvanmele tomvanmele removed this from the Release inside NCCR milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants