New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split S in EdDSA signature to prevent overflow #88

Closed

ThomasPiellard opened this issue Apr 16, 2021 · 0 comments

Assignees

Labels

bug

Collaborator

ThomasPiellard commented Apr 16, 2021

In std/signature/eddsa/, the scalar S in the signature can exceed r of the underlying snark field. S must be split in 2 to avoid this overflow.

ThomasPiellard added the bug label

ThomasPiellard self-assigned this

ThomasPiellard added a commit that referenced this issue


          fix: fixes #88

ThomasPiellard closed this as completed

gbotrel mentioned this issue

docs: added comments for the splitting of S in eddsa #89

Merged

gbotrel mentioned this issue

v0.4.0: Experimental PlonK support and user documentation #94

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment