-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a crate like opencontainers/selinux #2718
Comments
@utam0k |
Hey @Gekko0114 , do you need any help with this? |
Thanks, but I don't have enough time to work on these days.. |
I completely understand, no worries!
This is not exactly urgent, but given that this is an incorrect implementation , I would prefer to have it fixed sooner than later. I was just wondering if you are still planning to work on this or not, so pinged you. Take your time 💜 |
Sorry for not doing this task for a while. I will resume it.
|
No worries! Hey @Gekko0114 , I don't think I'll be able to help much in near future, but one thing I can suggest is we can implement this under the Also checking the files, |
Sure, thanks for your suggestion! SGTM. |
I agree with @YJDoc2 . It would be an good idea. |
I have a question. go-selinux handles xattr https://github.com/opencontainers/selinux/blob/main/go-selinux/selinux_linux.go#L346. However, https://github.com/nix-rust/nix doesn't seem to have functions handling xattr. Should I create a crate handling xattr as well? |
Hey regarding this, if the implementation of related xattr functions is not too complex, and there are not too many edge-cases to be considered, I'd prefer not to add a dependency to deal with it. For implementing it , I'd prefer to have it as a module in the same selinux crate instead of separate crate, so that we don't have to publish and manage two crates for this. wdyt? |
SGTM, thanks! Then I will add xattr function in one crate. |
background
In this PR #2688, it was found that the implementation of linux mount label is different between runc and youki.
What we will do
Youki should follow runc's implementation.
Therefore, we will implement the crate like opencontainers/selinux in this issue.
The text was updated successfully, but these errors were encountered: