Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contentful.AspNetCore Using Deprecated Packages #321

Open
edmacdonald opened this issue Oct 27, 2023 · 1 comment
Open

Contentful.AspNetCore Using Deprecated Packages #321

edmacdonald opened this issue Oct 27, 2023 · 1 comment

Comments

@edmacdonald
Copy link

Contentful.AspNetCore is referencing deprecated packages such as Microsoft.AspNetCore.Http.

Please use conditional references in your project file so those of us that want to use this in .net6+ don't have to drag in obsolete packages.

With this change, all tests passed.

  </ItemGroup>
    <ItemGroup Condition=" '$(TargetFramework)' != 'net462' and '$(TargetFramework)' != 'netstandard2.0' and '$(TargetFramework)' != 'netstandard2.1' ">
        <FrameworkReference Include="Microsoft.AspNetCore.App" />
    </ItemGroup>
    <ItemGroup Condition=" '$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'netstandard2.1' ">
        <PackageReference Include="Microsoft.AspNetCore.Http" Version="2.2.2" />
        <PackageReference Include="Microsoft.AspNetCore.Http.Abstractions" Version="2.2.0" />
        <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor" Version="2.2.0" />
        <PackageReference Include="Microsoft.AspNetCore.Razor" Version="2.2.0" />
        <PackageReference Include="Microsoft.AspNetCore.Razor.Runtime" Version="2.2.0" />
    </ItemGroup>
@Roblinde
Copy link
Collaborator

Roblinde commented Nov 5, 2023

Excellent suggestion, I'll take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants