-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalization by default #151
Comments
The normalization is a lazy way of addressing the fact that we may be summing together the synthesis of many instruments, so the output of the |
Hello there, is this issue still up for grabs? |
Yep! |
Hey,
currently there is a default normalization when using fluidsynth:
https://github.com/craffel/pretty-midi/blob/master/pretty_midi/pretty_midi.py#L940
Could we make this optional? This way different MIDI velocities are ignored...
Fluidsynth is producing 16-bit integer values...this normalization scales it such that the values lie in [-1, 1]. I would rather say we divide the fluidsynth output by 2^16 plus making the normalization optional.
What do folks think?
The text was updated successfully, but these errors were encountered: