Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Rework the examples to reduce code duplication and warnings #83

Open
orgarten opened this issue Apr 20, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@orgarten
Copy link
Collaborator

Describe the enhancement
The examples should be reworked at some point in time to reduce code duplication and especially to make it easier to fix the warnings.

E.g. using ft = double and partially templated code in combination with float inputs for the geometry leads to some type conversion warnings which are tedious to fix.

Expected behavior
I think there are two options:

  1. remove templates and use float for everything
  2. templatize everything and use static_casts where appropriate.

The end goal would be to get rid of all warnings during the compilation of the code.

@orgarten orgarten added enhancement New feature or request help wanted Extra attention is needed labels Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant