Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbltap should respect zoom.clickDistance. #180

Closed
mbostock opened this issue Aug 5, 2019 · 1 comment · Fixed by #216
Closed

dbltap should respect zoom.clickDistance. #180

mbostock opened this issue Aug 5, 2019 · 1 comment · Fixed by #216

Comments

@mbostock
Copy link
Member

mbostock commented Aug 5, 2019

We should only cancel the dbltap if the touchmove moves more than a certain distance from the touchstart position.
@mbostock mbostock mentioned this issue Aug 5, 2019
Closed
@Fil
Copy link
Member

Fil commented Jul 13, 2020

This should also solve the pencil dbl-tap issue (see #206). However it's probably not going to be the same factor depending on the type of input? The pencil always sends non-zero moves.

@Fil Fil mentioned this issue Jul 15, 2020
Merged
@Fil Fil closed this as completed in 3318746 Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(dbl) Tap distance d3/d3-zoom
2 participants
@Fil @mbostock