Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter share text handling improvements #62

Open
darklow opened this issue Jun 6, 2017 · 1 comment
Open

Twitter share text handling improvements #62

darklow opened this issue Jun 6, 2017 · 1 comment

Comments

@darklow
Copy link
Owner

darklow commented Jun 6, 2017

I am currently not satisfied with how SocialShareKit chooses tweet content and it is too complicated and unpredictable. Usually I end up with just rewrite whole networkUrl in onBeforeOpen method. Therefore I would like to hear your thoughts how should it be and I am willing to change behaviour for next version. Should it use twitter card details, should it use meta title & desription, or og:title and og:description tags as fallback. If yes, on what order etc. Thanks.

Also related #49 #56.

@dalej
Copy link

dalej commented Jun 7, 2017

There are essentially 2 problems with the current set up:

  1. Quite often the "twitter text" ends up as the TITLE duplicated (with a dash in between)
  2. Most always the "twitter text" is too long to fit into a Tweet - so the text presented to the User needs to be edited by the User before posting to Twitter.

How the logic appears to be currently working:

  • when there is Twitter Description: the Title is automatically added to the beginning of the Twitter Description along with the link and social address (creates very long tweets)
  • when there is no Twitter Description: the Title is used along with the automatically added Title to the blank Twitter Description are used along with the link and social address. (doubles up title)

Here is how the logic should work:

  • if there is no separate and unique Twitter Description available (for use via data-)_ only include the Title automatically along with the link, and social address
  • if there is a general Twitter Description only (via one of the several Meta tags) include the Twitter Description, link, and social address
  • never have the Title and Twitter Description added together. In other words, don't auto-include the Title to the Twitter Description It is one or the other.
  • limit the Twitter Description box in the CMS to about 93 characters

Overall, create logic that ensures that the overall tweet length is under the 140 character limit so Users need make no changes to the text to be able to successfully send the tweet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants