Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if non zero tx value works or not in forward_transact #1517

Open
hackfisher opened this issue Jun 25, 2024 · 2 comments
Open

Test if non zero tx value works or not in forward_transact #1517

hackfisher opened this issue Jun 25, 2024 · 2 comments
Assignees
@hujw77 @boundless-forest

Comments

@hackfisher
Copy link
Contributor

darwinia/pallet/staking/src/lib.rs

Line 1033 in 2dadcd4

value: U256::zero(),

@hackfisher
Copy link
Contributor Author

https://github.com/darwinia-network/kton-staker/blob/51fcac7e4ce2c4d80765c98bc544554b9f289b2e/src/staking/KtonDAOVault.sol#L41

@hujw77 hujw77 mentioned this issue Jun 25, 2024
Open
@boundless-forest
Copy link
Member

I checked the implementation about the forward_transact, it supports non-zero value, the behaviour is no different compared to the common usage. Any problems found here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hujw77 hujw77

@boundless-forest boundless-forest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hackfisher @hujw77 @boundless-forest