Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the StringSegment treatment #9

Open
sebastienros opened this issue Nov 13, 2017 · 3 comments
Open

Apply the StringSegment treatment #9

sebastienros opened this issue Nov 13, 2017 · 3 comments

Comments

@sebastienros
Copy link
Contributor

From the benchmarks I have done for the library where I am using Irony, I can say that it's allocating a lot of memory. I think that modifying the code base to use StringSegment would improve things a lot.

It might not be an easy change but would probably improve the overall performance. I might try to do it when I find the time.

@daxnet
Copy link
Owner

daxnet commented Nov 15, 2017

@sebastienros , Looks interesting. Please just go ahead. And the situation from my side is the same: do not have enough time during these days. ;(
Thanks for your effort. And by the way, I have some questions in defining my own LOGO programming language with Irony, if possible, could you please help?

@sebastienros
Copy link
Contributor Author

As far as I am knowledgeable, for sure.

@daxnet
Copy link
Owner

daxnet commented Nov 15, 2017

@sebastienros
Thank you!

Actually the grammar is defined here, which is not very complex, but when I open the compiled assembly by using the Irony Explorer, it shows me a Shift-Reduce conflict warning message. However when I use this grammar to do some parsing tests, everything works fine, I only see the warning in the Irony Explorer.

I know that it is because the ambiguous definition between the PARENTHESIS_EXPRESSION and the LPS + FUNCTION_ARGS + RPS portion in the FUNCTION_CALL definition that represents the function arguments, but I don't know how to eliminate this warning message. Do you have a good solution on that?

Appreciate your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants