Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Verify operator #1480

Open
timo95 opened this issue Feb 27, 2020 · 4 comments
Open

Rename Verify operator #1480

timo95 opened this issue Feb 27, 2020 · 4 comments

Comments

@timo95
Copy link
Contributor

timo95 commented Feb 27, 2020

The name is confusing and does not describe the operator. I would use RemoveDanglingEdges. It is verbose, but correct. Does anyone have a better idea?
@ChrizZz110
Copy link
Contributor

I agree. We should change the name.

@timo95 timo95 mentioned this issue Jan 13, 2021
Merged
8 tasks
@ChrizZz110
Copy link
Contributor

Problem here is that we used this call in several publications. Thus, we could change the name of the operator itself, but not of the Grala call (LogGraph.verify())

@timo95
Copy link
Contributor Author

timo95 commented Jan 13, 2021

We could add a call with the new name and deprecate the old call with a note why it isn't removed.

@ChrizZz110
Copy link
Contributor

Go for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrizZz110 @timo95