-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support poetry.lock
#70
Comments
That would be excellent. |
I implemented a very rudimentary and ugly poetry.lock reader here: https://github.com/vegai/python-license-check/tree/poetry_lock_support -- the POC was pretty trivial. If somebody wants to pick this up and implement it properly, feel free. If not, I'll probably be able to make it prettier and mergeable in a few days/weeks. |
So I probably knew when I was writing my last comment that it's a blatant lie. Anyway, perhaps some day it will happen that I get bored of exporting requirements.txt and rereading it here and then finish this. |
Does exporting from |
Yes. The following command sequence works great for me in all my Poetry projects.
|
I'd like to run it in pre-commit with poetry, but this would require a custom pre-commit hook. So having this "workaround" implemented in the package would be nice! Possibly it should also not be specific to poetry, but rather allow giving a command that generates a requirements.txt (this would allow to also e.g. enable Pipfile.lock) Also, maybe liccheck should just allow passing a requirements.txt file to stdin - then creating temporary files could be avoided. |
poetry
is a Python package manager that is gaining momentum as an alternative topip
.It provides a concrete
poetry.lock
describing the resolved dependencies of a project.Would it make sense to add a
poetry.lock
parsing module to this project to integrate smoothly withpoetry
projects?It might be sensible to add the parse as on extra to the project that would be installed with
liccheck[poetry]
. Depends if we use the poetry project to read the lock file.poetry
does have the functionality to generate arequirements.txt
so there is a work around possible.The text was updated successfully, but these errors were encountered: