Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use on libraries built with Windows line endings. #73

Open
FabianNiehaus opened this issue Jun 24, 2021 · 2 comments
Open

Allow use on libraries built with Windows line endings. #73

FabianNiehaus opened this issue Jun 24, 2021 · 2 comments

Comments

@FabianNiehaus
Copy link

We are currently having an issue with liccheck and version 17.3.0 of pyrsistent.

Liccheck always flags the package as unknown, due to the fact that there is a \r in the string, which is most likely an artifact from the Windows line break \r\n:

check unknown packages...
2 packages.
    pyrsistent (0.17.3): ['MIT License\r']
      dependency:
          pyrsistent << jsonschema

Other packages using the MIT license are parsed just fine.

I dug a bit into the metadata parsing and found that the metadata for pyrsistent: 17.3.0 indeed contains \r\n linebreaks, while all other packages have \n in their metadata. It probably got compiled on Windows with faulty settings regarding the line endings.

Is it possible to adjust the metadata parsing to support Windows line endings?

@FabianNiehaus
Copy link
Author

I also opened an issue in the pyrsistent repository: tobgu/pyrsistent#229

@MortenGrum
Copy link

I am having the same issue with:
wrapt (1.12.1): ['BSD License\r']
termcolor (1.1.0): ['MIT License\r']

Is there a workaround for these windows line endings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants