Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget middleware package does not detect crawlers #3

Open
bmcdaniels opened this issue Jun 7, 2018 · 7 comments
Open

Nuget middleware package does not detect crawlers #3

bmcdaniels opened this issue Jun 7, 2018 · 7 comments

Comments

@bmcdaniels
Copy link

bmcdaniels commented Jun 7, 2018

We're running a core 2.0 with MVC project using DotNetCoreOpen.PrerenderMiddleware. We found that it was not detecting the Google crawler (possibly others, but we have only tested Google). I double-triple checked the configs and startup to make sure everything was done correctly and it was. I removed the nuget package and created a local copy of this repo instead and it started working immediately with the same implementation.

Can this be looked into?

Great job on this by the way. It has really helped out.

@dingyuliang
Copy link
Owner

Hi, bmcdaniels:
I am glad this helps.
About this issue, would you please give the configuration and code which you used and didn't work.
I did make some changes after the nuget package was built.

Thanks.

@prayatna
Copy link

Hey @dingyuliang,
I'm having the same issue as @bmcdaniels
The v1.0.4 that you have seems to be working fine.
Would you be able to update the nuget package please?

@morkonom
Copy link

Same issue here. Please update the package, it would make things a lot easier for us.

@roqueernesto
Copy link

Same issue here. Please update the package, it would make things a lot easier for us.

Any update on this?? There is no v1.0.4 for .net core

@ervwalter
Copy link

ervwalter commented Aug 8, 2019

There are fixes in master branch in the repo, but a new nuget package with a new version number was never published.

  1. I cloned the repo, compiled the middleware myself, and referenced the compiled DLL.
  2. I manually specified a useragent pattern that includes googlebot and bingbot (these were fix in the .NET version, but not the .NET Core version):

"CrawlerUserAgentPattern": "(bingbot)|(googlebot)|(google)|(bing)|(Slurp)|(DuckDuckBot)|(YandexBot)|(baiduspider)|(Sogou)|(Exabot)|(ia_archiver)|(facebot)|(facebook)|(twitterbot)|(rogerbot)|(linkedinbot)|(embedly)|(quora)|(pinterest)|(slackbot)|(redditbot)|(Applebot)|(WhatsApp)|(flipboard)|(tumblr)|(bitlybot)|(Discordbot)",

@ervwalter
Copy link

Fixed in pull request #6

@MrPrashantT
Copy link

@dingyuliang will a new nuget version be published with the latest updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants