-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Q: Should we add code coverage to all repos? #15
Comments
The problem is that i see much codecov problems when i look at Phobos pull requests, so i'm against. |
Yes there were many problems and we had to eat quite some dogfood (also with the CodeCov guys). See also: dlang/phobos#5202 and dlang/phobos#5375 |
My concern is the red crosses. ❌ is repulsive imo. |
Understood. I have made two PRs to start an experiment: dlang-community/libdparse#144 What do you say about testing it out at one or two repos and then making a decision / further move? |
I am in favor of adding code coverage. Personally as a contributer or user of open-source projects I see code coverage as signal that the maintainers care about the quality of the project. I really can't see this as a way to repulse potential contributors. |
+1 |
I recently found out that CodeCov supports
There's also the possibility to use a very high threshold. See also: https://github.com/dlang/dmd/blob/master/.codecov.yml |
Imho it's very useful to see at a PR whether the touched lines are actually tested.
The text was updated successfully, but these errors were encountered: