Checks unification for MagickGeometry

[Gounlaf]

👋

MagickGeometry has internal check for dimensions (Percentage of absolute)

Magick.NET/src/Magick.NET/Types/MagickGeometry.cs

Lines 50 to 55 in 708c592

	public MagickGeometry(Percentage percentageWidth, Percentage percentageHeight)
	{
	Throw.IfNegative(nameof(percentageWidth), percentageWidth);
	Throw.IfNegative(nameof(percentageHeight), percentageHeight);
	InitializeFromPercentage(0, 0, (int)percentageWidth, (int)percentageHeight);

Magick.NET/src/Magick.NET/Types/MagickGeometry.cs

Lines 322 to 325 in 708c592

	public void Initialize(int x, int y, int width, int height)
	{
	Throw.IfNegative(nameof(width), width);
	Throw.IfNegative(nameof(height), height);

On some method (in MagickImage as example), same check has MagickGeometry is done:

Magick.NET/src/Magick.NET/MagickImage.cs

Lines 3474 to 3479 in 708c592

	public void InterpolativeResize(Percentage percentageWidth, Percentage percentageHeight, PixelInterpolateMethod method)
	{
	Throw.IfNegative(nameof(percentageWidth), percentageWidth);
	Throw.IfNegative(nameof(percentageHeight), percentageHeight);
	var geometry = new MagickGeometry(percentageWidth, percentageHeight);

On some others, it's not:

Magick.NET/src/Magick.NET/MagickImage.cs

Lines 3894 to 3897 in 708c592

	public void LiquidRescale(int width, int height)
	{
	var geometry = new MagickGeometry(width, height);
	LiquidRescale(geometry);

What do you prefer? Double check or reducing redundant calls?

I will do a PR to unify all checks depending on your preference.

Regards.

[dlemstra]

We can remove the redundant checks. But we might need some extra unit tests to make sure exceptions are still raised?

[Gounlaf]

All existing tests will be kept

[dlemstra]

You might need to add extra ones if I forgot to add them.

[Gounlaf]

Oh sure; that's not a problem 🙂

Will do a Draft PR soon and push several commits to make review easier.

[Gounlaf]

Note: Percentage class doesn't have checks like MagickGeometry. However, comments suggest it should have. It should have checks too, and, as well, redundant checks could be removed.

If you are ok with this too, I will do another PR, the current one focusing on MagickGeometry

[dlemstra]

I don't think we need negative percentages so it is probably a good idea to add checks for this.