Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage calculation does not update after power trick #203

Closed
BlackCapCoder opened this issue May 10, 2024 · 1 comment · Fixed by #212
Closed

Damage calculation does not update after power trick #203

BlackCapCoder opened this issue May 10, 2024 · 1 comment · Fixed by #212
Assignees
Labels
approved This will be worked on bug Something isn't working dank Good issue or request

Comments

@BlackCapCoder
Copy link

BlackCapCoder commented May 10, 2024

I reported this back in #143, which was fixed by #144, but it has become a problem again. Unlike last time we can now manually enable/disable power trick, so I can see that calcdex does correctly detect the presence of power trick, and it also correctly calculates my effective stats, however, those stats are not used for the purpose of damage calculation!

replay: https://play.pokemonshowdown.com/battle-gen7doublesou-2119518905

On turn 4, calcdex tells me that I have an 8HKO on Noivern with rock slide, but if I manually switch my att/def around (base stats and EVs) and change my nature, we see that it's really a 1HKO. Sure enough, Noivern goes down before it can setup tailwind- calcdex was lying to me.

@doshidak
Copy link
Owner

wowza, it's been exactly one year, hoooly. but glad you're still with us!

anyway, ya you're totally right, Power Trick wasn't actually doing the trick :o turns out I forgot to make the swap in a new stat override method I apparently added 2ish months after that PR LOL.

calcdex-power-trick-fix-fr-fr-ong

but I went ahead & got that fixed up for ya. will be available in this upcoming version, dropping soon. thanks for your report!! c:

@doshidak doshidak self-assigned this Jul 30, 2024
@doshidak doshidak added bug Something isn't working approved This will be worked on dank Good issue or request labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This will be worked on bug Something isn't working dank Good issue or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants