Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent issue with showdex crashing if i join a match via a showdown link #209

Closed
underscoreffyerauhfasf opened this issue Jul 7, 2024 · 1 comment · Fixed by #212
Assignees
Labels
approved This will be worked on bug Something isn't working dank Good issue or request

Comments

@underscoreffyerauhfasf
Copy link

every single time i join a match to spectate via a link, showdex crashes. if i leave the match and rejoin having already loaded showdown, everything works fine. below is a QR of one of the many crashes that happened, though i can provide more.

Device: ASUS X515J
OS: Windows 11
Browser: Opera
Showdex Version: v1.2.3
Format: Multiple, but in this instance Gen 9 Natdex

image

@doshidak
Copy link
Owner

oh wow, this one's actually a React rendering error (from the UI library that Showdex uses), not a damage calc one that we normally get hahah.

based on the error tho, I may have a sneaking suspicion of what it is :o I've encountered something similar in that error's ballpark during the development of this upcoming version (which speaking of, will be dropping real soon!). hopefully that will solve this, so I'll close this with that version's PR. feel free to open another one if you're still having issues & we'll go from there.

thanks!

@doshidak doshidak self-assigned this Jul 30, 2024
@doshidak doshidak added bug Something isn't working approved This will be worked on dank Good issue or request labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This will be worked on bug Something isn't working dank Good issue or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants