Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata view should not show wellknown/embedded attributes #22453

Closed
VSadov opened this issue Sep 30, 2017 · 5 comments
Closed

Metadata view should not show wellknown/embedded attributes #22453

VSadov opened this issue Sep 30, 2017 · 5 comments

Comments

@VSadov
Copy link
Member

VSadov commented Sep 30, 2017

image

None of the attributes are really expected in this view.
They do exist in metadata, but since we show something that looks like source, they should be mapped to language features.

This is not a valid syntax. I'd expect something like

public readonly ref struct ReadOnlySpan<T>

Not sure if this is a matter of symbol display (Compiler) or some higher layer in IDE.

@VSadov
Copy link
Member Author

VSadov commented Sep 30, 2017

I think this is 15.later since this is not directly visible

@VSadov
Copy link
Member Author

VSadov commented Sep 30, 2017

CC: @jcouv - for triage

@jasonmalinowski
Copy link
Member

Also adding @jinujoseph for IDE statements of how important this is. This is a pretty common feature...I'd be surprised if we didn't fix this up as we went along.

@CyrusNajmabadi
Copy link
Member

IMO, this is certainly something that should be fixed. But it's also not super critical. i.e. metadata-as-source is certainly not lying to you. It's showing you the metadata accurately. Of course, having it closer to the C# representation is def desirable, but that could come later (or be given up-for-grabs) for someone to take.

@jinujoseph jinujoseph modified the milestones: 15.later, Unknown Oct 12, 2017
@CyrusNajmabadi
Copy link
Member

This correct looks like this now:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants