-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Reflection.Metadata doesn't handle generic attributes #58073
Comments
Proactively adding to 6.0 - per @RikkiGibson and @tmat generic attributes will ship in 6.0 which means this scenario will be broken. The initial version of the implementation is in the PR above, missing tests. |
Looks like the PR you pointed to was closed. @tmat @RikkiGibson do we still want to get this in 6.0? is somebody going to finish the work that @MichalStrehovsky started? |
We are including the feature under the "preview" language version, which means it is not supported and it's expected that some things will still be broken in the upcoming .NET 6 release. If we are able to get more fixes related to the feature into .NET 6, then great, but it's not urgent right now. |
Got it, will mark this issue as net7.0 then for now. If we can still get it for 6.0 that would be great, but given the time window that seems like it could not make it in time. |
We get a BadImageFormatException if the custom attribute constructor refers to the T's of the owning type.
I have a fix in #57466 but I won't have time to write tests anytime soon. It's better if that's handled by the owners of S.R.M.
The text was updated successfully, but these errors were encountered: