Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user: set lang separate from home place #164

Open
synrg opened this issue Apr 4, 2022 · 1 comment
Open

user: set lang separate from home place #164

synrg opened this issue Apr 4, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request inat 🍃 iNaturalist cog user iNaturalist / Discord users

Comments

@synrg
Copy link
Collaborator

synrg commented Apr 4, 2022

Make it possible for the user to ,user set lang to set their language to be different from their home place language so that.

This was requested by @naturefold on iNaturalist Discord:

Is there any way to set it that dronefly doesn't show common names in German when I do ,t for example?

@synrg synrg added enhancement New feature or request inat 🍃 iNaturalist cog user iNaturalist / Discord users labels Apr 4, 2022
@synrg synrg self-assigned this Apr 4, 2022
@synrg
Copy link
Collaborator Author

synrg commented Apr 15, 2022

This is now partially implemented as of 15749c5 but it needs more work to consistently apply the language overrides in all cases. It would greatly help if the inconsistencies in the API layer were cleaned up.

Here's a non-exhaustive list of improvements that would help complete this feature:

  • a user's settings are applied to every call (i.e. via a client session)
  • the Taxon object is cleaned up and made consistent
  • any API calls bypassing the creation of a Taxon object are eliminated
  • the common name abstraction is moved onto the Taxon object
  • rethink whether it makes sense to use the common name in the named place when a user does a from query vs. always showing the user's preferred common name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request inat 🍃 iNaturalist cog user iNaturalist / Discord users
Projects
None yet
Development

No branches or pull requests

1 participant