Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netty Connector should close the connection #4610

Closed
olotenko opened this issue Oct 13, 2020 · 0 comments · Fixed by #4614
Closed

Netty Connector should close the connection #4610

olotenko opened this issue Oct 13, 2020 · 0 comments · Fixed by #4614
Labels
bug Something isn't working

Comments

@olotenko
Copy link

Unfortunately, the latest update to NettyConnector that added pool size limits does not close the connection that is not added to the pool:

https://github.com/eclipse-ee4j/jersey/blob/f5caafb/connectors/netty-connector/src/main/java/org/glassfish/jersey/netty/connector/NettyConnector.java#L274

This can be seen as a growing number of ESTABLISHED connections with low pool size.

netty_connector_pool_fix.zip - a POC fix that addresses the issue.
@jansupol jansupol added the bug Something isn't working label Oct 15, 2020
@senivam senivam mentioned this issue Oct 19, 2020
Merged
@senivam senivam linked a pull request Oct 19, 2020 that will close this issue
NettyConnector connection close #4614
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NettyConnector connection close senivam/jersey
2 participants
@jansupol @olotenko