Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hk2RequestScope.Instance logger is not static #4665

Closed
pettyjamesm opened this issue Dec 21, 2020 · 0 comments · Fixed by #4675
Closed

Hk2RequestScope.Instance logger is not static #4665

pettyjamesm opened this issue Dec 21, 2020 · 0 comments · Fixed by #4675
Labels
enhancement New feature or request
Milestone

Comments

@pettyjamesm
Copy link

It appears that Hk2RequestScope.Instance#logger is accidentally created once per instance instead of being declared static, which means it calls into the logging subsystem to get the logger instance on each request. The line of code in question can be found here:

private final ExtendedLogger logger = new ExtendedLogger(Logger.getLogger(Instance.class.getName()), Level.FINEST);

@jansupol jansupol added the enhancement New feature or request label Jan 6, 2021
@senivam senivam added this to the 2.34 milestone Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants