Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename "declare/undeclare" functions #489

Closed
milyin opened this issue Jul 1, 2024 · 1 comment
Closed

rename "declare/undeclare" functions #489

milyin opened this issue Jul 1, 2024 · 1 comment
Labels
release Part of the next release

Comments

@milyin
Copy link
Contributor

milyin commented Jul 1, 2024

Describe the release item

zc_liveliness_declare_token, zc_liveliness_undeclare_token
zcu_publisher_matching_listener_undeclare must follow the same pattern as other declare/undeclare functions - "zxx_declare_something" / "zxx_undeclare_something"
Related also to #367 - can be done together
@milyin milyin added the release Part of the next release label Jul 1, 2024
@milyin
Copy link
Contributor Author

milyin commented Aug 29, 2024

liveliness prefix serves like namespace, all liveliness related function have this prefix, so it's ok to have "undeclare" after it

@milyin milyin closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release Part of the next release
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@milyin