Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename "callback" variables/parameters #491

Open
milyin opened this issue Jul 2, 2024 · 0 comments
Open

rename "callback" variables/parameters #491

milyin opened this issue Jul 2, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@milyin
Copy link
Contributor

milyin commented Jul 2, 2024

Describe the release item

The structures are named "closure" and the closure have fields "context", "callback" and "drop"
@YuanYuYuan noticed that as the function's parameters and variable names are named "callback" too, this confuses user.

Maybe we should consider some renaming -e.g. name this parameter "closure" ?
@milyin milyin added release Part of the next release documentation Improvements or additions to documentation and removed release Part of the next release labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
Zenoh 1.0.0 release
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@milyin