Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zc_shm_client_list_add_client should accept the list as first parameter #498

Closed
milyin opened this issue Jul 3, 2024 · 2 comments
Closed
Assignees
Labels
release Part of the next release

Comments

@milyin
Copy link
Contributor

milyin commented Jul 3, 2024

Describe the release item

This function changes the list. I.e. it's kind of method of the list object and should accept list as first parameter.
It's necessary also to check other functions for arguments order.

pub extern "C" fn zc_shm_client_list_add_client(
    id: z_protocol_id_t,
    client: &mut z_owned_shm_client_t,
    list: &mut zc_loaned_shm_client_list_t,
) -> z_error_t {
    match client.as_rust_type_mut().take() {
        Some(client) => {
            list.as_rust_type_mut().push((id, client));
            Z_OK
        }
        None => Z_EINVAL,
    }
}
@milyin milyin added the release Part of the next release label Jul 3, 2024
@milyin
Copy link
Contributor Author

milyin commented Aug 4, 2024

This function itself is not important as it's shm and so unsable. But setting priority to high as we need to make review of other constructor function for parameters order

@milyin milyin self-assigned this Sep 4, 2024
@milyin
Copy link
Contributor Author

milyin commented Sep 4, 2024

reviewed API, result in issue #647, closing task

@milyin milyin closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Part of the next release
Projects
Status: Done
Development

No branches or pull requests

1 participant