Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pitch shifter accepts transpose < 0.0f but does not work #162

Open
jfsantos opened this issue Aug 18, 2021 · 1 comment
Open

Pitch shifter accepts transpose < 0.0f but does not work #162

jfsantos opened this issue Aug 18, 2021 · 1 comment

Comments

@jfsantos
Copy link

The pitch shifter implementation seems to only work for transpose > 0.0f, but the function takes a float as input. If the function does not allow transposing down, it should at least be indicated in the documentation? Or is it supposed to work and I am doing something wrong?

@stephenhensley
Copy link
Collaborator

@jbeda akaik the pitch shifter should accept negative values.

That said, I recall there being a bit of an issue with the math, and it not being semitone-accurate with a negative value. So it's possible someone added a clamp to prevent that.

Thanks for pointing this out, we'll look into it and get it fixed up ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants