Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose accent color in Granite.Settings #394

Closed
cassidyjames opened this issue May 13, 2020 · 3 comments · Fixed by #483
Closed

Expose accent color in Granite.Settings #394

cassidyjames opened this issue May 13, 2020 · 3 comments · Fixed by #483
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a bug; but a new feature or enhancement

Comments

@cassidyjames
Copy link
Contributor

cassidyjames commented May 13, 2020

Similar to #319. Requires elementary/default-settings#175.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@cassidyjames cassidyjames added Priority: Wishlist Not a bug; but a new feature or enhancement Needs Design Waiting for input from the UX team labels May 13, 2020
@danirabbit
Copy link
Member

Hm I’m not sure this is necessary. For apps, surely anything they want to do with accent color is CSS related right? And the greeter can read from dbus directly

@cassidyjames
Copy link
Contributor Author

@danrabbit I am not sure how we plan for flatpaked apps to get the default accent color (i.e. if they're not overriding it). I guess… this would be handled somehow by the Flatpak Platform setting the right stylesheet? But I have no idea how that works.

But if we tell developers to manually request a stylesheet, it would probably be good to request a stylesheet that matches the user's accent color preference unless the app has branding reasons to set their own accent color.

@Marukesu
Copy link
Contributor

From what I understand, in X11, flatpak use the system xsettings to get the theme, if it don't exist on the platform, Adwaita is used. But You can force a theme with the GTK.Settings Class in the application code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a bug; but a new feature or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants