Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly use asynchronous functions #287

Open
tintou opened this issue Mar 1, 2023 · 0 comments
Open

Properly use asynchronous functions #287

tintou opened this issue Mar 1, 2023 · 0 comments

Comments

@tintou
Copy link
Member

tintou commented Mar 1, 2023

We are using async functions in NetworkManager which is great, but actually getting a result can take some time.

For the quick actions, we should make the button insensitive or in intermediate state until we get the result from the async call.

Some settings (like the VPN I think) can be cancelled early if you click on the button again before it has been completed, using the GLib.Cancellable in the function call would do the trick there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants