Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose consultedNodes #728

Open
calebeby opened this issue Sep 2, 2021 · 1 comment
Open

Expose consultedNodes #728

calebeby opened this issue Sep 2, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@calebeby
Copy link
Contributor

calebeby commented Sep 2, 2021

Hi, is there a way to use the values of consultedNodes when calling computeAccessibleName or computeAccessibleDescription? Maybe we could add 2nd copies of those methods with different names that return an object { name/description: '...', consultedNodes: ... } to avoid breaking changes?

@eps1lon
Copy link
Owner

eps1lon commented Sep 3, 2021

Thanks for the feedback.

I think this makes sense so that you can work around the current limitation for title attributes. We currently would consider the title for both name and description. With the new implementation we could initialize the consulted nodes for computeAccessibleDescription with the consulted nodes from computeAccessibleName.

Maybe we could add 2nd copies of those methods with different names that return an object { name/description: '...', consultedNodes: ... } to avoid breaking changes?

I'd rather make a breaking change than having to maintain two versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants