Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine if Day is Valid before Render #14

Open
ericauv opened this issue Feb 6, 2019 · 0 comments
Open

Determine if Day is Valid before Render #14

ericauv opened this issue Feb 6, 2019 · 0 comments

Comments

@ericauv
Copy link
Owner

ericauv commented Feb 6, 2019

Should not pass activity.days[dayId] as a prop -- dayId should be passed and this day should be determined if valid for the activity within component.

  • Bullet
    isAfterToday and isBeforeCreationDate should be calculated within Bullet instead of passed as props.

  • DailyActivityDetails
    Should indicate that the activity is not valid for this day
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericauv