Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More for fixing MDNS #8675

Closed
d-a-v opened this issue Sep 13, 2022 · 3 comments · Fixed by #8705
Closed

More for fixing MDNS #8675

d-a-v opened this issue Sep 13, 2022 · 3 comments · Fixed by #8705
Assignees

Comments

@d-a-v
Copy link
Collaborator

d-a-v commented Sep 13, 2022

After @hreintke 's fix (#8641 from #8308), this notice and these lwIP guidelines brought to attention by @mcspr,

our mDNS implementation will benefit from part or all these suggestions:

@d-a-v d-a-v added this to the 3.1 milestone Sep 13, 2022
@d-a-v d-a-v self-assigned this Sep 13, 2022
@mcspr
Copy link
Collaborator

mcspr commented Sep 13, 2022

LwipIntf::stateUpCB()

s/LwipIntf::stateUpCB()/LwipIntf::ipChangeCB()/ ?
in case of DHCP, that would be called twice

Might be confusing for static ip? Need to check examples, though. Is it 'STATE UP -> set ip addresses' or 'set ip addresses -> STATE UP'?
In the referenced issue that was 'solved' by optional EXT callbacks feature within LWIP core, I don't see any callbacks in dhcp client. Same for auto-ip :/

@d-a-v
Copy link
Collaborator Author

d-a-v commented Sep 13, 2022

We can also considerate bringing interface DOWN then UP when IP changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants