Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeatedly check if payment pointer in monetization tag has changed #17

Closed
vezwork opened this issue May 31, 2020 · 2 comments · Fixed by #84
Closed

Repeatedly check if payment pointer in monetization tag has changed #17

vezwork opened this issue May 31, 2020 · 2 comments · Fixed by #84
Assignees
Labels
priority 1 Highest priority

Comments

@vezwork
Copy link
Member

vezwork commented May 31, 2020

  1. Repeatedly check if monetization tag payment pointer has changed. setinterval can be used. Could be checked every ~second.
  2. Save whether payment pointer has been validated recently. i.e. within the past hour.
  3. Validate payment pointers which have never been validated, or which have not been validated recently.

This data (and potentially also the logic) would fit well in the AkitaPaymentPointerData class.

@vezwork vezwork changed the title Repeatedly check if monetization tag payment pointer has changed Repeatedly check if payment pointer in monetization tag has changed May 31, 2020
@vezwork
Copy link
Member Author

vezwork commented May 31, 2020

Related discussion: #14 (comment)

@vezwork
Copy link
Member Author

vezwork commented Jun 13, 2020

Will fix the following problem:

  • If a user who is not using a payment provider visits twitch.tv, it will never be registered as monetized because sites are only registered when the page loads. Twitch.tv adds the monetization tag programmatically after the page loads so it will never be registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority 1 Highest priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants