Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee Recipient Post Merge (WIP) #23

Closed
james-prysm opened this issue Mar 3, 2022 · 5 comments
Closed

Fee Recipient Post Merge (WIP) #23

james-prysm opened this issue Mar 3, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@james-prysm
Copy link
Collaborator

Post Merge, consensus clients will need to set an Eth 1 account when running a validator/beacon Chain in order to receive the fees on processing transactions while proposing a block. Currently, PoS validators only receive funds from the protocol and do not receive fees on the transactions themselves. Users would like a way to tell the Validator Client/ Beacon Node to change the fee recipients dynamically while the system is running.

Each validator index ( not public key according to this api ethereum/beacon-APIs#178) can have a fee recipient.

@james-prysm james-prysm added enhancement New feature or request question Further information is requested labels Mar 3, 2022
@james-prysm
Copy link
Collaborator Author

How do we protect this endpoint 🤔 ? is it merged into the existing endpoints or separate?

@dapplion
Copy link
Collaborator

To clarify this would be added to a validator_client oapi file not the keymanager right? Drawing similarities, the keymanager API does not handle graffiti.

@g11tech
Copy link

g11tech commented Mar 17, 2022

To clarify this would be added to a validator_client oapi file not the keymanager right? Drawing similarities, the keymanager API does not handle graffiti.

I think thats the proposal: to have a patch request to update fee-recipient (and may be graffiti too). Then the validator will update the beacon using beacon proposer api call. Right @james-prysm ?

But wouldn't this also necessitate a mappings DB validator side, as far as you know, your current implementation has this mapping updated in db beacon side.

@james-prysm
Copy link
Collaborator Author

I think thats the proposal: to have a patch request to update fee-recipient (and may be graffiti too). Then the validator will update the beacon using beacon proposer api call. Right @james-prysm ?

right for dynamic updating otherwise it'll use the burn address if you don't use any of the validator flags

But wouldn't this also necessitate a mappings DB validator side, as far as you know, your current implementation has this mapping updated in db beacon side.

i have it stored in memory right now but if the validator restarts it should probably use the updated file? we have it persisting on the beacon node side.

@james-prysm james-prysm self-assigned this Apr 22, 2022
@james-prysm
Copy link
Collaborator Author

first spec used for fee recipient api merged in, closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants