Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more input options when creating stage items #612

Open
evroon opened this issue Mar 19, 2024 · 1 comment
Open

Allow more input options when creating stage items #612

evroon opened this issue Mar 19, 2024 · 1 comment
Labels
enhancement New feature or request Stale

Comments

@evroon
Copy link
Owner

evroon commented Mar 19, 2024

ref #611

Right now, you can only select the winners up to the 4th position for a subsequent stage item. Number 5 and up cannot be selected. We should allow that.

- 1st Group A vs 2nd Group B
- 2nd Group A vs 1st Group B
- 3rd Group A vs 4th Group B
- 4th Group A vs 3rd Group B
- 5th Group A vs 6th Group B
- 6th Group A vs 5th Group B

The last two options here aren't available.

We can either add all possible options to the dropdown, or set the max as a config value instead of hardcoded, or allow the user to set the max in the frontend.

The limit of four is hardcoded here:

for winner_position in range(1, 5):
results_tentative.append(
StageItemInputOptionTentative(
winner_from_stage_item_id=stage_item.id, winner_position=winner_position
)
)

@evroon evroon added the enhancement New feature or request label May 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

This issue is stale because it has been open for 60 days with no activity. What is the action to take here?

@github-actions github-actions bot added the Stale label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

1 participant