Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support Final Model Selection? #5

Closed
billdenney opened this issue Jul 15, 2018 · 2 comments
Closed

Feature Request: Support Final Model Selection? #5

billdenney opened this issue Jul 15, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@billdenney
Copy link

One of the methods that I often use for generating models in R is to make a list of candidate models and then evaluate which is the best to select as the final model by one or more metrics. For that, I've written an AIC method that can compare lists of formula and put it into the PKNCA package. It's not a good fit for the underlying goal of the package, and I'd like to find a better home for the function and a few related functions (AIC.list, get.best.model, and get.first.model) as briefly described in billdenney/pknca#71.

Would you be interested in including functions (with tests) with a pull request that does the following?

  • AIC.list: evaluate the AIC of a list of models.
    • AIC.logical: to handle NA in a list of models.
    • AIC.NULL: to handle NULL in a list of models.
  • get.best.model: select the best model from a list of models by minimum AIC.
  • get.first.model: select the first model that converged from a list of models.
@ewenharrison ewenharrison added the enhancement New feature or request label Jul 15, 2018
@ewenharrison
Copy link
Owner

Potentially. Although I'm not enthusiastic about model selection on AIC alone.
Finalfit functions with metrics==TRUE includes an AIC for models. On RStudio, this can appear as a list of metrics in the environment tab. So just by scanning down the models already fitted, the best AIC can be seen directly. Do you think the function adds significantly to that?
Many thanks for the interest. It is greatly appreciated.

@billdenney
Copy link
Author

Sorry for my long silence on this issue. As I thought about it more, I agree that it doesn't feel like a great fit for finalfit.

Thanks again for your work on the package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants