Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔧 esl-popup]: revisit esl-popup / esl-tooltip implementation (part 2 : follow-up) #2123

Open
3 tasks
ala-n opened this issue Dec 15, 2023 · 0 comments
Open
3 tasks

Comments

@ala-n
Copy link
Collaborator

ala-n commented Dec 15, 2023

Followup of #2010

Both esl-popup / esl-tooltip modules are in the beta stage but already have non-beta usage on the projects.
The goal of the story is the following points:

  • review and simplify esl-popup implementation, make it highly acceptable by code analyzing tools metrics
  • revisit documentation and standard features of esl-popup
  • check the esl-tooltip usages, and create a migration plan to make it public component:
    • esl-tooltip -> esl-note-tooltip
    • review esl-share-popup inheritance chain
    • create an actual esl-tooltip epic
  • check init flow - styles (there is no default styles for empty tag)

Scope:

  • immutable popup utilities
  • Extra attributes feature
  • A11ty: reuse focus mixins when ready
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant