Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[esl-carousel/presentation]: anchor support #2347

Open
ala-n opened this issue Apr 16, 2024 · 0 comments
Open

[esl-carousel/presentation]: anchor support #2347

ala-n opened this issue Apr 16, 2024 · 0 comments
Assignees
Labels
feature New feature

Comments

@ala-n
Copy link
Collaborator

ala-n commented Apr 16, 2024

It looks like we need to resolve the following subtopics:

  1. We need to create a way to auto-build anchor names for slide collection.
    It could be something like a computed value of 11ty data
    NOTE: Ideally, we considering migrating our sive-nav to use anchors instead of slide numbers

  2. Overal behaviour for countainers (it sounds like carousel should support it)
    In case of esl:show:request have dispatched from the slide inner content - the slide should became active
    Note: we could use that behaviour for anchor navigation, but it is unclear if it be suitable for us

  3. We need to create a carousel plugin to manage anchors:
    3.1) In case the slide is marked with an anchor (id or special attribute) we need to update URL (without page reload) with the appropriate anchor on the slide change
    3.2) If the anchor ij the URL changed (or initially presented) and the carousel have a slide with the same anchor -> we should open this slide

@ala-n ala-n added the feature New feature label Apr 16, 2024
@ala-n ala-n added this to the ⚡ESL: 5.0.0 Major release milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants