Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 TypeError - NoneType comparison to an int #211

Closed
DefiantBidet opened this issue Sep 16, 2020 · 3 comments
Closed

Python3 TypeError - NoneType comparison to an int #211

DefiantBidet opened this issue Sep 16, 2020 · 3 comments

Comments

@DefiantBidet
Copy link

DefiantBidet commented Sep 16, 2020

OctoPrint Version:

  • 1.4.2

octopi_version:

  • 0.17.0

python:

  • pip: 20.2.3
  • version: 3.7.3

PrintTimeGenius Version:

  • 2.2.5

What did you try:
Installing after updating to python3. Gcode sent to printer stuck in analysis phase and unable to print.
Manual analysis - which also failed and left an error log.

What happenned:
Error logged to ErrorLog
TypeError: '<' not supported between instances of 'NoneType' and 'int'
In python 3 you can not compare a NoneType to an int. this is being done on line 188 of /octoprint_PrintTimeGenius/__init__.py.
Line in question - here

What did you expect to happen:
Plugin to not crash due to logic errors introduced in language upgrade.
To be able to print gcode sent to printer - and not have this plugin prevent that

Sample of Error Log:

2020-09-15 21:41:59,470 - octoprint - ERROR - Exception on /plugin/PrintTimeGenius/analyze/local/[local-directory]/[file_name].gcode [GET]
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 523, in analyze_file
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/__init__.py", line 322, in analyse
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/analysis.py", line 98, in dequeue
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/analysis.py", line 198, in dequeue
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 207, in _do_abort
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 188, in _allow_analysis
2020-09-15 21:42:30,079 - octoprint - ERROR - Exception on /plugin/PrintTimeGenius/analyze/local/[local-directory]/[file_name].gcode [GET]
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 523, in analyze_file
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/__init__.py", line 322, in analyse
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/analysis.py", line 98, in dequeue
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/analysis.py", line 198, in dequeue
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 207, in _do_abort
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 188, in _allow_analysis
2020-09-15 21:42:33,891 - octoprint - ERROR - Exception on /plugin/PrintTimeGenius/analyze/local/[local-directory]/[file_name].gcode [GET]
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 523, in analyze_file
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/__init__.py", line 322, in analyse
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/analysis.py", line 98, in dequeue
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/analysis.py", line 198, in dequeue
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 207, in _do_abort
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 188, in _allow_analysis
2020-09-15 21:42:43,142 - octoprint - ERROR - Exception on /plugin/PrintTimeGenius/analyze/local/[local-directory]/[file_name].gcode [GET]
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 523, in analyze_file
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/__init__.py", line 322, in analyse
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/analysis.py", line 98, in dequeue
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/analysis.py", line 198, in dequeue
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 207, in _do_abort
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 188, in _allow_analysis
2020-09-15 21:43:58,997 - octoprint.plugins.pluginmanager - INFO - Loaded plugin notices data from https://plugins.octoprint.org/notices.json
2020-09-15 21:44:50,303 - octoprint - ERROR - Exception on /plugin/PrintTimeGenius/analyze/local/[local-directory]/[file_name].gcode [GET]
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 523, in analyze_file
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/__init__.py", line 322, in analyse
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/analysis.py", line 98, in dequeue
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/filemanager/analysis.py", line 198, in dequeue
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 207, in _do_abort
  File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_PrintTimeGenius/__init__.py", line 188, in _allow_analysis
2020-09-15 21:45:08,764 - octoprint.server.heartbeat - INFO - Server heartbeat <3
@DefiantBidet
Copy link
Author

looks as if this is related to 210

@DefiantBidet
Copy link
Author

#212 should resolve this issue

@DefiantBidet
Copy link
Author

#212 Merged - resolves this issue. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant