Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up rooms / players once a player is disconnected #8

Open
delphinemillet opened this issue Apr 4, 2019 · 4 comments
Open

Clean up rooms / players once a player is disconnected #8

delphinemillet opened this issue Apr 4, 2019 · 4 comments

Comments

@delphinemillet
Copy link

To reproduce:

  • go online
  • create a room
  • copy the url
  • remove text from /room to the end from the url
  • paste the copied url
    (after 2 attempts)
    image
  • leave the room
  • you can join it again
@fabienjuif fabienjuif self-assigned this Apr 6, 2019
@fabienjuif
Copy link
Owner

I don't reproduce or I didn't understand the issue.
Could you try next time I publish the game?

@fabienjuif
Copy link
Owner

I just published a new version, can you try to reproduce it?

@delphinemillet
Copy link
Author

I can reproduce.
Steps:

  • go online
  • create a room
  • copy the url
  • remove text after .org from url and press Enter
  • paste the copied url

@fabienjuif fabienjuif reopened this Apr 9, 2019
@fabienjuif
Copy link
Owner

fabienjuif commented Apr 9, 2019

Ok, this is not the "same player".
This is another player (another id), with same name.

What I didn't have yet, is user disconnection.
There is no event (server side) attached to the client socket to catch its disconnection.

@fabienjuif fabienjuif removed their assignment Apr 9, 2019
@fabienjuif fabienjuif changed the title User can join the same room multiple times Clean up rooms / players once a player is disconnected Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants