Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in extract-text-webpack-plugin #1668

Closed
3 tasks
Timer opened this issue Feb 27, 2017 · 11 comments
Closed
3 tasks

Bugs in extract-text-webpack-plugin #1668

Timer opened this issue Feb 27, 2017 · 11 comments

Comments

@Timer
Copy link
Contributor

Timer commented Feb 27, 2017

@Timer Timer added this to the 0.10.0 milestone Feb 27, 2017
@gaearon
Copy link
Contributor

gaearon commented Feb 27, 2017

Only related to WP2? Not for 0.9 branch?

@Timer
Copy link
Contributor Author

Timer commented Feb 27, 2017

Only related to webpack-2 afaik, issues are tagged so and are related to wp2 features.

@gaearon
Copy link
Contributor

gaearon commented Apr 18, 2017

This is worrying me. I need to start working on integrating the PWA stuff, and it seems like we'd have to backport it to 0.9.x since Webpack 2 is not ready 😞

@Timer
Copy link
Contributor Author

Timer commented Apr 18, 2017

I believe this never worked in WP 1 (with require.ensure), I see some older issues mentioning require.ensure.
If we don't enable performance hints (yet) we won't be bugging people to move to import(), and thus not in a worse position.

@Timer
Copy link
Contributor Author

Timer commented Apr 18, 2017

Full disclosure I haven't actually tested these issues to see if they're present, but since they're open, tagged, and +1'd I assume they're valid.

@gaearon
Copy link
Contributor

gaearon commented Apr 19, 2017

OK I think we can live with this.

@gaearon
Copy link
Contributor

gaearon commented Apr 19, 2017

At least webpack-contrib/extract-text-webpack-plugin#188 only happens in watch mode so it doesn’t affect us.

@joshwiens
Copy link
Contributor

@Timer / @gaearon - Anything like this where you have blocking / aggravating bugs with something living under webpack-contrib tag me directly or @webpack-contrib/org-maintainers so we can get them on the high priority list and addressed.

@Timer
Copy link
Contributor Author

Timer commented May 5, 2017

Thanks for letting us know @d3viant0ne, we would love to see webpack-contrib/extract-text-webpack-plugin#406 fixed especially if we're going to turn on performance hints.

@gaearon gaearon modified the milestones: 0.11.0, 0.10.0 May 8, 2017
@joshwiens
Copy link
Contributor

@Timer - On the off chance you haven't seen it, @sokra is attacking the performance problem at it's source as opposed to trying to stick a bandaid on ExtractText.

https://medium.com/webpack/the-new-css-workflow-step-1-79583bd107d7

More info as it becomes available :)

@gaearon
Copy link
Contributor

gaearon commented Jan 8, 2018

Closing as stale. (Blockers have since been fixed.)

@gaearon gaearon closed this as completed Jan 8, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants