Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash navigation breaks in 3.4.0 with some plugins #10307

Closed
3 of 7 tasks
razzeee opened this issue Jul 17, 2024 · 1 comment · Fixed by #10311
Closed
3 of 7 tasks

Hash navigation breaks in 3.4.0 with some plugins #10307

razzeee opened this issue Jul 17, 2024 · 1 comment · Fixed by #10311
Labels
bug An error in the Docusaurus core causing instability or issues with its execution external This issue is caused by an external dependency and not Docusaurus.

Comments

@razzeee
Copy link
Contributor

razzeee commented Jul 17, 2024

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

We're using https://github.com/gabrielcsapo/docusaurus-plugin-search-local and updating to 3.4.0 changes the links the search produces.

They end up in a duplicated format like https://docs.flathub.org/docs/for-app-authors/linter/docs/for-app-authors/linter#linter-errors instead of https://docs.flathub.org/docs/for-app-authors/linter#linter-errors

See
gabrielcsapo/docusaurus-plugin-search-local#82

I couldn't spot a hint at a behaviour change in the changelog, but I might have overlooked it or this is a regression.

The new hashnav changes are opt in so far it seems?

Reproducible demo

flathub-infra/documentation#339

Steps to reproduce

  1. run yarn
  2. yarn build
  3. yarn serve
  4. Go to the page
  5. Search for linter error
  6. Click the first result

Expected behavior

It should route you to the correct path and scroll down to the hash navigation

Actual behavior

You get a 404

Your environment

Self-service

  • I'd be willing to fix this bug myself.
@razzeee razzeee added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Jul 17, 2024
@razzeee razzeee changed the title Hash navigation breaks in 3..4.0 with some plugins Hash navigation breaks in 3.4.0 with some plugins Jul 17, 2024
@slorber slorber removed the status: needs triage This issue has not been triaged by maintainers label Jul 18, 2024
@slorber
Copy link
Collaborator

slorber commented Jul 18, 2024

See my answer here: gabrielcsapo/docusaurus-plugin-search-local#82 (comment)

Although we have our responsibility, Docusaurus core works fine and this is a third-party plugin bug.

@slorber slorber closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2024
@slorber slorber added the external This issue is caused by an external dependency and not Docusaurus. label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution external This issue is caused by an external dependency and not Docusaurus.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants