Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy object doesn't actually do anything in Hermes debugger console #761

Closed
1 task
jkester1986 opened this issue Jun 14, 2022 · 7 comments
Closed
1 task
Labels
bug Something isn't working

Comments

@jkester1986
Copy link

Bug Description

  • I have run gradle clean and confirmed this bug does not occur with JSC

Hermes version: 0.11
React Native version (if any): 0.68
OS version (if any): iOS (any)
Platform (most likely one of arm64-v8a, armeabi-v7a, x86, x86_64): Mac (both M1 and intel)

Steps To Reproduce

  1. Open Hermes Debugger console

  2. Try to copy object
    image

  3. Object does not copy

The Expected Behavior

Object is copied to clipboard

@jkester1986 jkester1986 added the bug Something isn't working label Jun 14, 2022
@mattbfb
Copy link
Contributor

mattbfb commented Aug 25, 2022

Hi @jkester1986,

I'm trying to reproduce this locally with a comparable object, and am getting a populated result when copying and pasting.

Can you share a specific instance that fails to copy so we can investigate further? Thanks!

@jkester1986
Copy link
Author

jkester1986 commented Aug 26, 2022

@dinhduongson
Copy link

I get the same issue :(

@mattbfb
Copy link
Contributor

mattbfb commented Sep 9, 2022

I'm having trouble reproducing this locally. To help narrow down the source of the issue, could you share the communication that happens when you choose "Copy Object"?

You can print the communication logs by starting Metro in debug mode, (e.g. DEBUG=Metro:InspectorProxy npx react-native start), then carrying out the actions in Hermes Debugger.

@mattbfb
Copy link
Contributor

mattbfb commented Sep 9, 2022

Ah, the RN version may play a role in this as well, as this part of the codebase has changed in recent versions. Does this issue occur on the current version of RN?

@jkester1986
Copy link
Author

Unfortunately I cannot upgrade right now, I get a couple different errors when trying to run the simulator:

 ERROR  Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'., js engine: hermes
 ERROR  Invariant Violation: Failed to call into JavaScript module method AppRegistry.runApplication(). Module has not been registered as callable. Registered callable JavaScript modules (n = 11): Systrace, JSTimers, HeapCapture, SamplingProfiler, RCTLog, RCTDeviceEventEmitter, RCTNativeAppEventEmitter, GlobalPerformanceLogger, JSDevSupportModule, HMRClient, RCTEventEmitter.
        A frequent cause of the error is that the application entry file path is incorrect. This can also happen when the JS bundle is corrupt or there is an early initialization error when loading React Native., js engine: hermes

I know what the first one is from (react-native-camera and react-native-snap-carousel packages), but not sure about the second. Unfortunately I don't currently have the time dig into this further due to work priorities.

@mattbfb
Copy link
Contributor

mattbfb commented Oct 6, 2022

I believe this is working as expected in the current version of React Native. If we can get a reproduction on the current version we can certainly investigate further.

As is, I believe the best path forward would be to upgrade to the current version. Otherwise, I believe newer features of the debug system would need to be back-ported to older version of RN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants