Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dim Background on Modal Display #12478

Closed
RachelGreenberger opened this issue Feb 20, 2017 · 5 comments
Closed

Dim Background on Modal Display #12478

RachelGreenberger opened this issue Feb 20, 2017 · 5 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@RachelGreenberger
Copy link

RachelGreenberger commented Feb 20, 2017

Description

Expected default behavior of modals on mobile devices, is that on dispaly of the modal, the background page dims. Currently, the transparent property of the Modal component sets the background to either transparent or white. It would make more sense to have 3 options for background: transparent, white or rgba(0,0,0,0.5) - dim.

Reproduction

Default behavior of modal transparent property.

Solution

I was able to change the code that when transparent is false, it dims the background. However, it would be more correct to allow the user to select from a wider range of options.

backgroundColor: this.props.transparent ? 'transparent' : 'rgba(0,0,0,0.5)',

Dim Background on Modal Display

Additional Information

  • React Native version: Latest
  • Platform: Android
  • Operating System: MacOS
@hramos
Copy link
Contributor

hramos commented May 25, 2017

We're cutting down on the number of outstanding issues, in order to allow us to focus. I'm closing this issue because it has been open for over 60 days with no activity. If you think it should still be opened let us know why. PRs are always welcome.

@hramos hramos closed this as completed May 25, 2017
@hramos hramos added the Icebox label May 26, 2017
@johngoren
Copy link

I think it should be opened, it's weird not to have this feature.

@conor909
Copy link

conor909 commented Nov 16, 2017

@hramos I think it should be opened, there is a library (referenced below) with a number of followers that is trying to imitate it, but the library doesn't work properly without this feature. It would be a popular feature since a lot of people want iOSActionSheets that can take any children, such as the Picker module

@ghost
Copy link

ghost commented Mar 15, 2018

This issue should be opened. This is an essential feature as far as the UX is concerned.

@hramos
Copy link
Contributor

hramos commented Mar 15, 2018

Please open a new issue.

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants