Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Move all data file manipulation to MephistoDB #567

Open
1 of 2 tasks
JackUrb opened this issue Sep 20, 2021 · 2 comments
Open
1 of 2 tasks

[Refactor] Move all data file manipulation to MephistoDB #567

JackUrb opened this issue Sep 20, 2021 · 2 comments
Labels
fix Small fixes and cleanups quick

Comments

@JackUrb
Copy link
Contributor

JackUrb commented Sep 20, 2021

Overview

At the moment a number of the classes we use in Mephisto for storing data or preparing task information are managed by classes outside of the MephistoDB. This prevents us from reaching our ideal state of fully abstracting out the storage backend from the data being collected. While not necessarily high-priority to resolve at the moment, this PR documents the locations where this abstraction is leaking.

Ultimately, many individuals' tasks may find it better to continue doing direct writes in AgentState's for instance, but we should strive for clean abstractions internally.

Implementation plan

  • Create file writing abstractions in the MephistoDB
  • Update all callsites with this TODO tag to use the MephistoDB abstract writes instead.
@JackUrb JackUrb added the fix Small fixes and cleanups label Sep 20, 2021
@JackUrb JackUrb mentioned this issue Feb 1, 2022
3 tasks
@Etesam913
Copy link
Contributor

This should be closed right?

@JackUrb
Copy link
Contributor Author

JackUrb commented Jul 12, 2022

The core of it is now implemented, but some code in the Mephisto codebase direct writes to and reads from files even when a db is accessible. I'll close this once those are all cleaned up.

@JackUrb JackUrb added the quick label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Small fixes and cleanups quick
Projects
None yet
Development

No branches or pull requests

2 participants