You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment a number of the classes we use in Mephisto for storing data or preparing task information are managed by classes outside of the MephistoDB. This prevents us from reaching our ideal state of fully abstracting out the storage backend from the data being collected. While not necessarily high-priority to resolve at the moment, this PR documents the locations where this abstraction is leaking.
Ultimately, many individuals' tasks may find it better to continue doing direct writes in AgentState's for instance, but we should strive for clean abstractions internally.
Implementation plan
Create file writing abstractions in the MephistoDB
Update all callsites with this TODO tag to use the MephistoDB abstract writes instead.
The text was updated successfully, but these errors were encountered:
The core of it is now implemented, but some code in the Mephisto codebase direct writes to and reads from files even when a db is accessible. I'll close this once those are all cleaned up.
Overview
At the moment a number of the classes we use in Mephisto for storing data or preparing task information are managed by classes outside of the MephistoDB. This prevents us from reaching our ideal state of fully abstracting out the storage backend from the data being collected. While not necessarily high-priority to resolve at the moment, this PR documents the locations where this abstraction is leaking.
Ultimately, many individuals' tasks may find it better to continue doing direct writes in
AgentState
's for instance, but we should strive for clean abstractions internally.Implementation plan
The text was updated successfully, but these errors were encountered: