Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable сustom HTTP header for external integrations (Loki, Grafana, etc.) #401

Closed
ir0njaw opened this issue Mar 2, 2023 · 2 comments
Labels
kind/feature New feature or request
Milestone

Comments

@ir0njaw
Copy link

ir0njaw commented Mar 2, 2023

Motivation

My Loki instance is behind a proxy that requires a custom header for authentication before forwarding the request to Loki. The current implementation of Falcosidekick does not allow adding a custom header to the request.

Feature

Allow users to configure the custom HTTP Header for various external integrations, in particular Loki.

for example:
--set falcosidekick.config.loki.customHeader="X-token: 12345"

POST /loki/api/v1/push HTTP/1.1
Host: 1.2.3.4:3100
User-Agent: Falcosidekick
X-token: 12345
Content-Length: 532
Content-Type: application/json
Accept-Encoding: gzip
@ir0njaw ir0njaw added the kind/feature New feature or request label Mar 2, 2023
@Issif Issif added this to the 2.28.0 milestone Mar 2, 2023
@Issif
Copy link
Member

Issif commented Mar 2, 2023

Nice idea, I will work on that asap

@Issif
Copy link
Member

Issif commented Mar 6, 2023

I will not consider the pure SAAS outputs or not HTTP protocol, here's the list of outputs that could benefit new headers:

  • Rocketchat
  • Mattermost
  • InfluxDB
  • Alertmanager
  • Elasticsearch
  • Loki
  • Grafana
  • NodeRed
  • CloudEvents
  • Kafka REST
  • OpenFAAS
  • WebUI
  • Zincsearch
  • Gotify
  • Tekton

It's a lot, I'll focus on few as nobody else requested this feature for now:

  • Loki
  • Grafana
  • Elasticsearch

Is that ok for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants