-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messes with back/forward history navigation #27
Comments
Does that happen even if you don't interact with Module Linker at all (by clicking on links it generates)? |
Yes. I have the same issue sometimes. |
Yes, when not clicking the module links. |
I can't reproduce that, but it is probably being caused by jquery-pjax. How frequent are these issues? Is it somewhat related to GitHub loading times? When it happens, does GitHub show that blue bar on the top, as if it was loading the page (when you press the back button)? If there are errors on the console, can you paste them here? |
It's related to
No.
No errors. |
I've tried it multiple times, alternating pauses, reloading and trying again and again and again. Got nothing. I'm on Firefox, however. |
I use Chrome sometimes, on other computers with Module Linker installed, and don't remember seeing that error there too. 😅 Anyway, ok, let me say this: when I said I couldn't reproduce I wasn't doubting you or that the bug existed, I just meant I couldn't see the bug on my computer, so I couldn't debug it or fix it. I was saying basically that I needed help debugging and fixing it. |
@fiatjaf OK, thank you. Now it's stable for me: Open Also, you can try to give me some version of extension with debugging output (to console), I think, because now console is really empty. |
Oops, there isn't any of that. If you're really into it you might want to download the source code from GitHub, spread out some But it is ok if you don't want that work. I'll try to find this error again later. |
I offered to make a debug version you, because you know better where in the code there are critical places and which state is better to track.
And I don't have much free time and skills with JS + |
I was able to reproduce. It's probably related to jquery.pjax, as it is used by GitHub itself, but also by Module Linker (so we can have the same navigation features of GitHub). The way I glued it into the code was somewhat hacky, because it doesn't seem to do what I was expecting it to do (probably my misunderstanding), so I bet the answer lies there. I need some help here, please. |
Does Will this bug reproducing without |
The Maybe what's happening is that when we press |
When I'm on GitHub in a source file (history index
n
) and go back in chrome (n-1
), sometimes only the URL bar changes to the previous (n-1
) URL but the content stays the same (n
), when this extension is installed.Then I have to reload or go back (
n-2
) and forward (ton-1
) to get to that page (n-1
).This shouldn't happen, please fix it :)
The text was updated successfully, but these errors were encountered: