Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y concerns: Missing visual focus indicator, elements not accessible by the Keyboard #108

Open
greydnls opened this issue Jan 12, 2021 · 2 comments

Comments

@greydnls
Copy link

greydnls commented Jan 12, 2021

Hi, I'm using version 3.2 of filestack-react, with this configuration:

const options = {
    onSuccess,
    onError,
    apikey: FILEPICKER_API_KEY,
    componentDisplayMode: {
      type: 'immediate',
    },
    actionOptions: {
      container,
      onUploadStarted,
      accept: ['.pdf', '.doc', '.docx'],
      displayMode: 'inline',
      fromSources: ['local_file_system', 'url', 'github', 'googledrive'],
      lang: LANGUAGE,
      storeTo: { workflows: [FILEPICKER_WORKFLOW_ID] },
    },
  };

  return <ReactFilestack {...options} />;

This renders the picker, and works as expected, generally. There are a few accessibility errors we're noticing, though. I don't see any way to override this behavior, so I thought I would open up an issue.

  1. None of the buttons highlighted in the image below are accessible by keyboard. Additionally, they are lacking labels and in some cases roles, which makes them hard to use with a screen reader.

Screen Shot 2021-01-12 at 3 00 55 PM

  1. The dropzone itself never registers as being "active", when you tab into it.
    This:
    image
    Versus the expected (achieved by manually giving that element focus):
    image

  2. The file upload input item doesn't have a valid label. Possible solutions, fix any of the following:

  • provide aria-label attribute
  • provide aria-labelledby attribute that references a valid element
  • Add an implicit (wrapped)
  • Add an explicit
  • add title attribute

Thanks for all your work on this tool, and thanks in advance for considering this issue. Please let me know if you need more information or if there's something I've missed in my setup.

@sarahbilly
Copy link

I would also love to see this resolved!

@jjun14
Copy link

jjun14 commented Nov 8, 2022

Bumping this issue, would love to see this addressed soon 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants