-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protobuf 3.12 causes a clang compilation error on Messaging pod v6.14 #5722
Comments
@M1ke Thanks for the report. Your proposal seems reasonable if there is a definite issue with 3.12.0. However, first we'd need to confirm that with a reproducible example. Protobuf 3.12.0 has been out for two weeks. Our testing does not show the problem and we haven't seen any other reports. It's possible you have a stale/corrupt Xcode state or some other environment issue. Does Are you able to reproduce in https://github.com/firebase/quickstart-ios/tree/master/messaging? |
Thanks for getting back to me. As far as I could see I tried every possible way of clearing my environment:
The same result happened each time. My only other thought is that it could be happening with one of React Native's autolinked pods, which is quite hard to debug. I'm using the default React Native pods plus:
All of these are autolinked except |
Does the issue still occur with the latest release - 6.26.0? It might be worth raising this on a react-native channel. Most people here aren't too familiar with that environment. |
I got issue with Protobuf 3.12 too, but it's a bit different from @M1ke .
Clearing cache does not help. Environment: |
@xiao99xiao That issue sounds more like something caused by stale or corrupt Xcode state. |
@xiao99xiao check your runtime search paths and make sure that Protobuf's build location is discoverable. |
I'm having the same issue as @M1ke . Tried with this environment:
I get the error when trying to archive, building and running are working ok. This is the error message:
The problem seems to be in Protobuf 3.12. The only quick-fix is manually editing Podfile.lock? |
@danigv Recent versions of Firebase require at least Xcode 10.3. It should never be necessary to edit the Podfile.lock versus specifying constraints in the Podfile like |
@paulb777 @morganchen12 One thing I noticed is, if I target at simulators, everything is ok, app starts properly, but if I target at a real iPhone, app runs into error at start. I doubt maybe Protobuf fails to build but Xcode doesn't recognized that issue. Guess I need to check the build destination directory to see if Protobuf framework is there. |
We're likely going to need a reproducible test case to make progress on this issue. |
Hey @M1ke. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically. If you have more information that will help us get to the bottom of this, just add a comment! |
Since there haven't been any recent updates here, I am going to close this issue. @M1ke if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this. |
Step 1: Describe your environment
CocoaPods
(select one)Step 2: Describe the problem
Steps to reproduce:
What happened? How can we make the problem occur?
See protocolbuffers/protobuf#7587 for the full error message.
In short: using Pod 6.14 for Firebase messaging requires Protobuf with definition
Protobuf (>= 3.9.2, ~> 3.9)
which at present requires Protobuf pod3.12
The linked Protobuf compilation error above occurs with this version, potentially due to protocolbuffers/protobuf#7026.
The fix is fairly simple; downgrade Protobuf to
3.11.x
which has to be done by hacking one'sPodfile.lock
Would it be acceptable if I opened a PR to hard limit the Protobuf requirement to max out at
3.11.x
on the6.14
branch for Messaging?The text was updated successfully, but these errors were encountered: